Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: 路由参数存在非英文字符的情况下 会生成一个新的tab 而非返回原有tab #3832

Merged
merged 1 commit into from May 14, 2024

Conversation

7kyun
Copy link
Contributor

@7kyun 7kyun commented May 11, 2024

例如 tabA的fullpath为 /test?username=测试
关闭 tabB,本应该返回 tabA
但是由于 replace 会把 「测试」进行转义为「%E6%B5%8B%E8%AF%95」
因此最后会打开一个新的 tabC 为 /test?username=%E6%B5%8B%E8%AF%95
tabA 和 tabC 实际为同一个

General

✏️ Mark the necessary items without changing the structure of the PR template.

  • Pull request template structure not broken

Type

ℹ️ What types of changes does your code introduce?

👉 Put an x in the boxes that apply

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist

ℹ️ Check all checkboxes - this will indicate that you have done everything in accordance with the rules in CONTRIBUTING.

👉 Put an x in the boxes that apply.

  • My code follows the style guidelines of this project
  • Is the code format correct
  • Is the git submission information standard?
  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@wangjue666
Copy link
Member

能否提供个视频演示下这个问题复现

@7kyun
Copy link
Contributor Author

7kyun commented May 14, 2024

能否提供个视频演示下这个问题复现

演示

example

此时pinia中的tablist

example

@wangjue666 wangjue666 merged commit 1fee161 into vbenjs:main May 14, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants