Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: change short month name for August for consistency with moment.js configuration #6609

Open
wants to merge 1 commit into
base: development
Choose a base branch
from

Conversation

crestf
Copy link

@crestf crestf commented Sep 15, 2023

Description:
I have noticed that ngx-bootstrap uses the 'id' locale configuration, based on moment.js locale configuration. However, there is a difference in the short month name for 'August'—moment.js uses 'Agt,' while ngx-bootstrap uses 'Ags.' This inconsistency leads to a different display in my project, which utilizes both ngx-bootstrap and moment.js configurations.

As an Indonesian myself, I propose following moment.js locale configuration, as it has become more common lately to abbreviate the month name 'August' as 'Agt.'

Reference to moment.js locale configuration: https://github.com/moment/moment/blob/develop/locale/id.js#L19
Reference to ICU locale for Indonesia (id-ID): https://www.localeplanet.com/icu/id-ID/index.html

PR Checklist

Before creating new PR, please take a look at checklist below to make sure that you've done everything that needs to be done before we can merge it.

  • read and followed the CONTRIBUTING.md guide.
  • built and tested the changes locally.
  • added/updated tests.
  • added/updated API documentation.
  • added/updated demos.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants