Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(carousel): tries to update itemsPerSlide #6249

Draft
wants to merge 3 commits into
base: development
Choose a base branch
from

Conversation

SvetlanaMuravlova
Copy link
Contributor

feat(carousel): tries to update itemsPerSlide
refs #5723 #5963

@SvetlanaMuravlova SvetlanaMuravlova linked an issue Jul 30, 2021 that may be closed by this pull request
@valorkin valorkin temporarily deployed to ngx-bootstra-feat-dynam-rupxa1 July 30, 2021 10:22 Inactive
@github-actions
Copy link

github-actions bot commented Jul 30, 2021

Visit the preview URL for this PR (updated for commit 7661bcc):

https://ngx-bootstrap-demo--pr6249-feat-dynamic-perslid-bc7smb9g.web.app

(expires Fri, 06 Aug 2021 11:02:19 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

@codecov
Copy link

codecov bot commented Jul 30, 2021

Codecov Report

Merging #6249 (10b3726) into development (c0beddb) will increase coverage by 0.36%.
The diff coverage is 100.00%.

❗ Current head 10b3726 differs from pull request most recent head 7661bcc. Consider uploading reports for the commit 7661bcc to get more accurate results
Impacted file tree graph

@@               Coverage Diff               @@
##           development    #6249      +/-   ##
===============================================
+ Coverage        77.55%   77.91%   +0.36%     
===============================================
  Files              302      302              
  Lines            10549    10556       +7     
  Branches          2583     2584       +1     
===============================================
+ Hits              8181     8225      +44     
+ Misses            2358     2321      -37     
  Partials            10       10              
Impacted Files Coverage Δ
src/carousel/carousel.component.ts 49.72% <100.00%> (+8.68%) ⬆️
src/carousel/utils.ts 93.75% <0.00%> (+56.25%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c0beddb...7661bcc. Read the comment docs.

@cypress
Copy link

cypress bot commented Jul 30, 2021



Test summary

86 1 6 0


Run details

Project ngx-bootstrap
Status Failed
Commit 10b3726 ℹ️
Started Jul 30, 2021 11:03 AM
Ended Jul 30, 2021 11:08 AM
Duration 05:03 💡
OS Linux Ubuntu - 20.04
Browser Electron 87

View run in Cypress Dashboard ➡️


Failures

src/integration/carousel_page_spec.ts Failed
1 Carousel page testing suite > Basic > when user click on left/right arrow - previous/next slide shown

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

@valorkin valorkin temporarily deployed to ngx-bootstra-feat-dynam-rupxa1 July 30, 2021 10:52 Inactive
@valorkin valorkin temporarily deployed to ngx-bootstra-feat-dynam-rupxa1 July 30, 2021 10:57 Inactive
@SvetlanaMuravlova SvetlanaMuravlova marked this pull request as draft July 30, 2021 12:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dynamic itemsPerSlide on carousel
3 participants