Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#1761 added Vatican City mobile validation #2397

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

#1761 added Vatican City mobile validation #2397

wants to merge 1 commit into from

Conversation

SurajSivakumar07
Copy link

Added Vatican City mobile validation

Checklist

  • ☑️ PR contains only changes related; no stray files, etc.
  • ☑️ README updated (where applicable)
  • ☑️ Tests written (where applicable)
  • ☑️ References provided in PR (where applicable)

WikiRik
WikiRik suggested changes May 7, 2024
View reviewed changes
Copy link
Member

@WikiRik WikiRik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please undo the stylistic changes and conform to our linter. After that has been changed we can review this

rubiin
rubiin suggested changes May 10, 2024
View reviewed changes
Copy link
Member

@rubiin rubiin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Make sure not to enforce any stylistic changes like mentioned in earlier comment. Otherwise its good to go

@rubiin rubiin added the 🧹 needs-update For PRs that need to be updated before landing label May 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rubiin rubiin rubiin requested changes

@WikiRik WikiRik WikiRik requested changes

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
🧹 needs-update For PRs that need to be updated before landing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@SurajSivakumar07 @rubiin @WikiRik