Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(isMobilePhone): add validation for Kyrgyzstan [ky-KG] mobile phone numbers #2350

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

feat(isMobilePhone): add validation for Kyrgyzstan [ky-KG] mobile phone numbers #2350

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/lib/isMobilePhone.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -118,7 +118,7 @@ const phones = {
'kk-KZ': /^(\+?7|8)?7\d{9}$/,
'kl-GL': /^(\+?299)?\s?\d{2}\s?\d{2}\s?\d{2}$/,
'ko-KR': /^((\+?82)[ \-]?)?0?1([0|1|6|7|8|9]{1})[ \-]?\d{3,4}[ \-]?\d{4}$/,
'ky-KG': /^(\+?7\s?\+?7|0)\s?\d{2}\s?\d{3}\s?\d{4}$/,
'ky-KG': /^(\+996\s?)?(22[0-9]|50[0-9]|55[0-9]|70[0-9]|75[0-9]|77[0-9]|880|990|995|996|997|998)\s?\d{3}\s?\d{3}$/,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Upon quick comparison with the latest PDF of the ITU ( https://www.itu.int/oth/T0202000074/en ), I notice some missing mobile phone numbers. For example the relatively new +996 60 0 XXX XXX is missing, but also phone numbers from Table 3 (pages 7 and 8). Could you go through that document and update the regular expression accordingly?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I can, but the information in the document is not up-to-date.

The numbers +996 60 0 XXX XXX are not used by the mobile operator beeline.kg (Sky Mobile LLC). You can check the list of all available codes here - https://nomer.beeline.kg/#/

As for the numbers on pages 7 and 8, the mobile operators (Aktel, Katel) no longer provide their services.
I found this information, but it's on Russian language.

about KATEL
about Aktel

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Certainly, here is the additional information:

+996 56X XXXXXX - Mobile - Winline (Sapatcom) - The operator is not operational.
+996 57X XXXXXX - Mobile - Sotel (Nexi) - The operator is not operational.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These companies went bankrupt and closed even before the pandemic. : )

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@WikiRik hello!
I wanted to follow up on my previous comment from 5 days ago. I'm looking forward to hearing your response. If you have any questions or need further clarification, please feel free to ask.

Thank you in advance for your attention.

'lt-LT': /^(\+370|8)\d{8}$/,
'lv-LV': /^(\+?371)2\d{7}$/,
'mg-MG': /^((\+?261|0)(2|3)\d)?\d{7}$/,
Expand Down
47 changes: 38 additions & 9 deletions test/validators.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8961,15 +8961,44 @@ describe('Validators', () => {
{
locale: 'ky-KG',
valid: [
'+7 727 123 4567',
'+7 714 2396102',
'77271234567',
'0271234567',
],
invalid: [
'02188565377',
'09386932778',
'0938693277vadggjdsaasdgj8',
'+996553033300',
'+996 222 123456',
'+996 500 987654',
'+996 555 111222',
'+996 700 333444',
'+996 770 555666',
'+996 880 777888',
'+996 990 999000',
'+996 995 555666',
'+996 996 555666',
'+996 997 555666',
'+996 998 555666',
],
invalid: [
'+996 201 123456',
'+996 312 123456',
'+996 3960 12345',
'+996 3961 12345',
'+996 3962 12345',
'+996 3963 12345',
'+996 3964 12345',
'+996 3965 12345',
'+996 3966 12345',
'+996 3967 12345',
'+996 3968 12345',
'+996 511 123456',
'+996 522 123456',
'+996 561 123456',
'+996 571 123456',
'+996 624 123456',
'+996 623 123456',
'+996 622 123456',
'+996 609 123456',
'+996 100 12345',
'+996 100 1234567',
'996 100 123456',
'0 100 123456',
'0 100 123abc',
],
},
{
Expand Down