Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restore use of cache mounts #1613

Open
wants to merge 8 commits into
base: main
Choose a base branch
from

Conversation

electrofelix
Copy link
Contributor

Adjust syntax used for cache mounts to align with a format supported
by both buildah and docker.

@coveralls
Copy link

coveralls commented Sep 28, 2022

Pull Request Test Coverage Report for Build 4774368844

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.2%) to 77.409%

Totals Coverage Status
Change from base Build 4773022767: 0.2%
Covered Lines: 2964
Relevant Lines: 3829

💛 - Coveralls

@electrofelix
Copy link
Contributor Author

This will need buildah 1.26 available in the runner.

@github-actions
Copy link

github-actions bot commented Nov 3, 2022

Download the latest artifacts for this pull request here:

@electrofelix electrofelix reopened this Nov 3, 2022
@electrofelix electrofelix force-pushed the restore-docker-caching branch 2 times, most recently from 7c65a36 to 76d0963 Compare November 3, 2022 17:51
@electrofelix
Copy link
Contributor Author

@dcermak it looks like the version of buildah on the Ubuntu runners work with the mount cache. When I tested this before with https://github.com/vagrant-libvirt/vagrant-libvirt/actions/runs/3147154713/jobs/5116377272 I got the impression that the buildah version wasn't quite new enough and thought 1.26 would be required.

However looking through the history of https://github.com/actions/runner-images/blob/main/images/linux/Ubuntu2204-Readme.md I'm not seeing any indication that buildah was changed in the mean time, nor when I put up a test workflow did it appear that the version had moved on from 1.23.1.

Since it's a bit unclear why it started to work before a new minor release, wondering if you could check this PR change locally to make sure I'm not re-introducing something that will break for other distros where buildah is in use? I've checked it locally and I'm still seeing the same error as before and I'm running 22.04 myself, so I'm a bit wary now of what buildah is actually in the runners.

@electrofelix
Copy link
Contributor Author

@dcermak never mind, I just spotted my mistake, forgot to update buildah to use the correct ref given I've moved the workflow to use pull_request_target.

@dcermak
Copy link
Contributor

dcermak commented Nov 4, 2022

@dcermak never mind, I just spotted my mistake, forgot to update buildah to use the correct ref given I've moved the workflow to use pull_request_target.

Ok, I got confused 😅 because it builds fine with buildah 1.27 on my machine.

@github-actions
Copy link

A docker image containing the code from this plugin to allow testing locally without installing
can be pulled from: ghcr.io/vagrant-libvirt/vagrant-libvirt:pr-1613-slim

If you need the image with the full dev toolchain, you can instead pull: ghcr.io/vagrant-libvirt/vagrant-libvirt:pr-1613

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants