Split uptodate state

[parlt91]

What does this PR change?

Split the uptodate state into uptodate, reboot and rebootifneeded.
Force reboot state to be last in order for recurring states.
Don't allow rebootifneeded and reboot to be used together.

GUI diff

No difference.

• DONE

Documentation

• TODO Documentation PR

• DONE

Test coverage

• No tests:

• DONE

Links

Issue(s): https://github.com/SUSE/spacewalk/issues/22483

• DONE

Changelogs

Make sure the changelogs entries you are adding are compliant with https://github.com/uyuni-project/uyuni/wiki/Contributing#changelogs and https://github.com/uyuni-project/uyuni/wiki/Contributing#uyuni-projectuyuni-repository

If you don't need a changelog check, please mark this checkbox:

• No changelog needed

If you uncheck the checkbox after the PR is created, you will need to re-run changelog_test (see below)

Re-run a test

If you need to re-run a test, please mark the related checkbox, it will be unchecked automatically once it has re-run:

• Re-run test "changelog_test"
• Re-run test "backend_unittests_pgsql"
• Re-run test "java_pgsql_tests"
• Re-run test "schema_migration_test_pgsql"
• Re-run test "susemanager_unittests"
• Re-run test "javascript_lint"
• Re-run test "spacecmd_unittests"

Before you merge

Check How to branch and merge properly!

[github-actions]

👋 Hello! Thanks for contributing to our project.
Acceptance tests will take some time (aprox. 1h), please be patient ☕
You can see the progress at the end of this page and at https://github.com/uyuni-project/uyuni/pull/8718/checks
Once tests finish, if they fail, you can check 👀 the cucumber report. See the link at the output of the action.
You can also check the artifacts section, which contains the logs at https://github.com/uyuni-project/uyuni/pull/8718/checks.

If you are unsure the failing tests are related to your code, you can check the "reference jobs". These are jobs that run on a scheduled time with code from master. If they fail for the same reason as your build, it means the tests or the infrastructure are broken. If they do not fail, but yours do, it means it is related to your code.

Reference tests:

• https://github.com/uyuni-project/uyuni/actions/workflows/acceptance_tests_secondary_parallel.yml?query=event%3Aschedule

• https://github.com/uyuni-project/uyuni/actions/workflows/acceptance_tests_secondary.yml?query=event%3Aschedule

KNOWN ISSUES

Sometimes the build can fail when pulling new jar files from download.opensuse.org . This is a known limitation. Given this happens rarely, when it does, all you need to do is rerun the test. Sorry for the inconvenience.

For more tips on troubleshooting, see the troubleshooting guide.

Happy hacking!
⚠️ You should not merge if acceptance tests fail to pass. ⚠️

[github-actions]

Suggested tests to cover this Pull Request

• srv_first_settings
• proxy_cobbler_pxeboot
• srv_monitoring
• srv_rename_hostname
• proxy_as_pod_basic_tests
• proxy_branch_network
• allcli_sanity

[cbbayburt]

LGTM 👍 (I haven't tried the new states though)

[Etheryte]

Looks good. 👍

[parlt91]

@admd @deneb-alpha We were discussing during our standup if we could/should include this for GA. It's not a bug fix, but rather some small quality of life addition for users. Do you think we can put it in or should we wait for 1. MU?

[deneb-alpha]

@admd @deneb-alpha We were discussing during our standup if we could/should include this for GA. It's not a bug fix, but rather some small quality of life addition for users. Do you think we can put it in or should we wait for 1. MU?

From RC we are in feature freeze and unless I understood this GH issue wrong, the split is not fixing any bug or broken feature. Given that, I would personally prefer to see these changes in the first MU, but it's up to @admd to decide.

[admd]

@admd @deneb-alpha We were discussing during our standup if we could/should include this for GA. It's not a bug fix, but rather some small quality of life addition for users. Do you think we can put it in or should we wait for 1. MU?

From RC we are in feature freeze and unless I understood this GH issue wrong, the split is not fixing any bug or broken feature. Given that, I would personally prefer to see these changes in the first MU, but it's up to @admd to decide.

I agree with Marina. This can wait for 1st MU.