Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Speed-up mgrutil.remove_ssh_known_host runner function #8715

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

agraul
Copy link
Member

@agraul agraul commented May 13, 2024

What does this PR change?

mgrutil.remove_ssh_known_host uses Salt's ssh.rm_known_host function. ssh.rm_known_host computes the path to the known_hosts file if that is not passed. This computation can take a long time because it uses the generic user.info function, which can be slow when users configure e.g. winbindd to provide user/group information.

We now bypass this potentially expensive computation and try to find the config file ourselves.

GUI diff

No difference.

  • DONE

Documentation

  • No documentation needed: only internal and user invisible changes

  • DONE

Test coverage

  • No tests: we don't have environments where we can test the runtime performance of "slow" directory servers.

  • DONE

Links

Issue(s): https://github.com/SUSE/spacewalk/issues/24171
Port(s): https://github.com/SUSE/spacewalk/pull/24315

  • DONE

Changelogs

Make sure the changelogs entries you are adding are compliant with https://github.com/uyuni-project/uyuni/wiki/Contributing#changelogs and https://github.com/uyuni-project/uyuni/wiki/Contributing#uyuni-projectuyuni-repository

If you don't need a changelog check, please mark this checkbox:

  • No changelog needed

If you uncheck the checkbox after the PR is created, you will need to re-run changelog_test (see below)

Re-run a test

If you need to re-run a test, please mark the related checkbox, it will be unchecked automatically once it has re-run:

  • Re-run test "changelog_test"
  • Re-run test "backend_unittests_pgsql"
  • Re-run test "java_pgsql_tests"
  • Re-run test "schema_migration_test_pgsql"
  • Re-run test "susemanager_unittests"
  • Re-run test "javascript_lint"
  • Re-run test "spacecmd_unittests"

Before you merge

Check How to branch and merge properly!

`mgrutil.remove_ssh_known_host` uses Salt's `ssh.rm_known_host`
function. `ssh.rm_known_host` computes the path to the `known_hosts`
file if that is not passed. This computation can take a long time
because it uses the generic `user.info` function, which can be slow when
users configure e.g. winbindd to provide user/group information.

We now bypass this potentially expensive computation and try to find the
config file ourselves.
@agraul agraul requested a review from a team as a code owner May 13, 2024 14:25
@agraul agraul requested review from meaksh and removed request for a team May 13, 2024 14:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants