Speed-up mgrutil.remove_ssh_known_host runner function #8715
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR change?
mgrutil.remove_ssh_known_host
uses Salt'sssh.rm_known_host
function.ssh.rm_known_host
computes the path to theknown_hosts
file if that is not passed. This computation can take a long time because it uses the genericuser.info
function, which can be slow when users configure e.g. winbindd to provide user/group information.We now bypass this potentially expensive computation and try to find the config file ourselves.
GUI diff
No difference.
Documentation
No documentation needed: only internal and user invisible changes
DONE
Test coverage
No tests: we don't have environments where we can test the runtime performance of "slow" directory servers.
DONE
Links
Issue(s): https://github.com/SUSE/spacewalk/issues/24171
Port(s): https://github.com/SUSE/spacewalk/pull/24315
Changelogs
Make sure the changelogs entries you are adding are compliant with https://github.com/uyuni-project/uyuni/wiki/Contributing#changelogs and https://github.com/uyuni-project/uyuni/wiki/Contributing#uyuni-projectuyuni-repository
If you don't need a changelog check, please mark this checkbox:
If you uncheck the checkbox after the PR is created, you will need to re-run
changelog_test
(see below)Re-run a test
If you need to re-run a test, please mark the related checkbox, it will be unchecked automatically once it has re-run:
Before you merge
Check How to branch and merge properly!