Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimize AppStreams related queries #8713

Merged
merged 2 commits into from
May 17, 2024

Conversation

wweellddeerr
Copy link
Contributor

What does this PR change?

It fixes suseServerAppStreamHiddenPackagesView by considering the stream column when joining suseAppstream and suseServerAppstream tables and includes new indexes to optimize the queries on it.

GUI diff

No difference.

  • DONE

Documentation

  • No documentation needed: only internal and user invisible changes

  • DONE

Test coverage

  • No tests: already covered

  • DONE

Links

Issue(s): https://github.com/SUSE/spacewalk/issues/24195

  • DONE

Changelogs

Make sure the changelogs entries you are adding are compliant with https://github.com/uyuni-project/uyuni/wiki/Contributing#changelogs and https://github.com/uyuni-project/uyuni/wiki/Contributing#uyuni-projectuyuni-repository

If you don't need a changelog check, please mark this checkbox:

  • No changelog needed

If you uncheck the checkbox after the PR is created, you will need to re-run changelog_test (see below)

Re-run a test

If you need to re-run a test, please mark the related checkbox, it will be unchecked automatically once it has re-run:

  • Re-run test "changelog_test"
  • Re-run test "backend_unittests_pgsql"
  • Re-run test "java_pgsql_tests"
  • Re-run test "schema_migration_test_pgsql"
  • Re-run test "susemanager_unittests"
  • Re-run test "javascript_lint"
  • Re-run test "spacecmd_unittests"

Before you merge

Check How to branch and merge properly!

@cbbayburt
Copy link
Contributor

Thanks, @wweellddeerr for the fix. The indexing looks fine to me, but when I try the new schema on my setup, I still see a significant performance drop on the "Install" tab. While "Upgrade" and "List/Remove" tabs load in ~2s, the "Install" tab still loads in ~12s. I'm afraid we'll have to go the materialized view way in the end, or somehow rethink the whole approach.

@admd
Copy link
Contributor

admd commented May 17, 2024

@cbbayburt @wweellddeerr does this mean that for now, we don't merge this PR?

@cbbayburt
Copy link
Contributor

@cbbayburt @wweellddeerr does this mean that for now, we don't merge this PR?

@admd I'm still working on this one. I'll add another commit on top and mark it ready soon.

@cbbayburt cbbayburt requested a review from a team as a code owner May 17, 2024 11:58
Copy link
Contributor

👋 Hello! Thanks for contributing to our project.
Acceptance tests will take some time (aprox. 1h), please be patient ☕
You can see the progress at the end of this page and at https://github.com/uyuni-project/uyuni/pull/8713/checks
Once tests finish, if they fail, you can check 👀 the cucumber report. See the link at the output of the action.
You can also check the artifacts section, which contains the logs at https://github.com/uyuni-project/uyuni/pull/8713/checks.

If you are unsure the failing tests are related to your code, you can check the "reference jobs". These are jobs that run on a scheduled time with code from master. If they fail for the same reason as your build, it means the tests or the infrastructure are broken. If they do not fail, but yours do, it means it is related to your code.

Reference tests:

KNOWN ISSUES

Sometimes the build can fail when pulling new jar files from download.opensuse.org . This is a known limitation. Given this happens rarely, when it does, all you need to do is rerun the test. Sorry for the inconvenience.

For more tips on troubleshooting, see the troubleshooting guide.

Happy hacking!
⚠️ You should not merge if acceptance tests fail to pass. ⚠️

@cbbayburt
Copy link
Contributor

After the last commit, here are the performance results:

Original: not eliminating duplicates
Execution Time: 343.752 ms

Before: eliminating duplicates with a CTE
Execution Time: 5279.493 ms

After: eliminating duplicates with aggregation
Execution Time: 345.210 ms

Copy link
Member

@rjmateus rjmateus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@admd admd merged commit a0e11eb into uyuni-project:master May 17, 2024
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants