Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduced Awaitility to handle async test code #8678

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

mackdk
Copy link
Contributor

@mackdk mackdk commented Apr 30, 2024

What does this PR change?

This PR introduces Awaitility, a new test-only dependency to handle and simplify async code in tests. This change is meant to ease async code testing and reduce flakyness.

GUI diff

No difference.

  • DONE

Documentation

  • No documentation needed: only internal and user invisible changes

  • DONE

Test coverage

  • Unit tests were updated

  • DONE

Changelogs

Make sure the changelogs entries you are adding are compliant with https://github.com/uyuni-project/uyuni/wiki/Contributing#changelogs and https://github.com/uyuni-project/uyuni/wiki/Contributing#uyuni-projectuyuni-repository

If you don't need a changelog check, please mark this checkbox:

  • No changelog needed

If you uncheck the checkbox after the PR is created, you will need to re-run changelog_test (see below)

Re-run a test

If you need to re-run a test, please mark the related checkbox, it will be unchecked automatically once it has re-run:

  • Re-run test "changelog_test"
  • Re-run test "backend_unittests_pgsql"
  • Re-run test "java_pgsql_tests"
  • Re-run test "schema_migration_test_pgsql"
  • Re-run test "susemanager_unittests"
  • Re-run test "javascript_lint"
  • Re-run test "spacecmd_unittests"

Before you merge

Check How to branch and merge properly!

Copy link
Contributor

Suggested tests to cover this Pull Request

@mackdk mackdk force-pushed the fix-attestation-flacky-tests branch 2 times, most recently from 62625f2 to d74eb15 Compare May 1, 2024 00:38
@mackdk mackdk force-pushed the fix-attestation-flacky-tests branch from 693a177 to 3b0d37a Compare May 15, 2024 12:47
@mackdk mackdk requested a review from lucidd May 15, 2024 12:50
@mackdk mackdk marked this pull request as ready for review May 15, 2024 14:35
@mackdk mackdk requested a review from a team as a code owner May 15, 2024 14:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants