Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve unit test isolation #8673

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

mackdk
Copy link
Contributor

@mackdk mackdk commented Apr 26, 2024

What does this PR change?

This PR improves unit test isolation to avoid problems when run in a different order.

GUI diff

No difference.

  • DONE

Documentation

  • No documentation needed: only internal and user invisible changes

  • DONE

Test coverage

  • Tests have been improved

  • DONE

Changelogs

Make sure the changelogs entries you are adding are compliant with https://github.com/uyuni-project/uyuni/wiki/Contributing#changelogs and https://github.com/uyuni-project/uyuni/wiki/Contributing#uyuni-projectuyuni-repository

If you don't need a changelog check, please mark this checkbox:

  • No changelog needed

If you uncheck the checkbox after the PR is created, you will need to re-run changelog_test (see below)

Re-run a test

If you need to re-run a test, please mark the related checkbox, it will be unchecked automatically once it has re-run:

  • Re-run test "changelog_test"
  • Re-run test "backend_unittests_pgsql"
  • Re-run test "java_pgsql_tests"
  • Re-run test "schema_migration_test_pgsql"
  • Re-run test "susemanager_unittests"
  • Re-run test "javascript_lint"
  • Re-run test "spacecmd_unittests"

Before you merge

Check How to branch and merge properly!

Copy link
Contributor

👋 Hello! Thanks for contributing to our project.
Acceptance tests will take some time (aprox. 1h), please be patient ☕
You can see the progress at the end of this page and at https://github.com/uyuni-project/uyuni/pull/8673/checks
Once tests finish, if they fail, you can check 👀 the cucumber report. See the link at the output of the action.
You can also check the artifacts section, which contains the logs at https://github.com/uyuni-project/uyuni/pull/8673/checks.

If you are unsure the failing tests are related to your code, you can check the "reference jobs". These are jobs that run on a scheduled time with code from master. If they fail for the same reason as your build, it means the tests or the infrastructure are broken. If they do not fail, but yours do, it means it is related to your code.

Reference tests:

KNOWN ISSUES

Sometimes the build can fail when pulling new jar files from download.opensuse.org . This is a known limitation. Given this happens rarely, when it does, all you need to do is rerun the test. Sorry for the inconvenience.

For more tips on troubleshooting, see the troubleshooting guide.

Happy hacking!
⚠️ You should not merge if acceptance tests fail to pass. ⚠️

Copy link
Contributor

Suggested tests to cover this Pull Request
  • proxy_cobbler_pxeboot
  • srv_monitoring
  • srv_rename_hostname
  • proxy_branch_network
  • allcli_sanity
  • srv_handle_config_channels_with_ISS_v2
  • sle_ssh_minion
  • srv_user_configuration_salt_states
  • proxy_register_as_minion_with_script
  • min_salt_formulas
  • min_deblike_salt
  • minssh_move_from_and_to_proxy
  • min_rhlike_salt
  • min_bootstrap_api
  • min_recurring_action
  • srv_group_union_intersection
  • srv_first_settings
  • min_salt_formulas_advanced
  • min_config_state_channel_api
  • srv_cobbler_profile
  • min_salt_minions_page
  • min_empty_system_profiles
  • allcli_config_channel
  • min_virthost
  • min_ssh_tunnel
  • min_action_chain
  • min_config_state_channel_subscriptions
  • buildhost_osimage_build_image
  • min_move_from_and_to_proxy
  • min_bootstrap_script
  • min_activationkey
  • min_bootstrap_reactivation
  • srv_maintenance_windows
  • proxy_as_pod_basic_tests
  • sle_minion
  • min_deblike_ssh
  • min_salt_mgrcompat_state
  • min_config_state_channel
  • min_rhlike_ssh
  • minssh_action_chain
  • buildhost_bootstrap
  • minssh_bootstrap_api
  • allcli_system_group
  • proxy_retail_pxeboot_and_mass_import
  • min_bootstrap_ssh_key

@mackdk mackdk force-pushed the improve-unit-test-isolation branch from ed457eb to fc2fb26 Compare April 30, 2024 12:39
@mackdk mackdk force-pushed the improve-unit-test-isolation branch from fc2fb26 to 599e526 Compare May 17, 2024 08:13
@mackdk mackdk requested review from cbosdo and mcalmer May 17, 2024 08:13
Copy link
Contributor

@mcalmer mcalmer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mackdk mackdk marked this pull request as ready for review May 17, 2024 13:12
@mackdk mackdk requested a review from a team as a code owner May 17, 2024 13:12
@mackdk mackdk requested review from nadvornik and removed request for a team May 17, 2024 13:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants