Make jre folder platform dependent #632
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
piiertho
previously approved these changes
May 18, 2024
|
I tested linux editor and export templates. Could you test windows and mac? (I don't think testing on mobile is necessary but you can if you want to :-) ) |
CedNaru
requested changes
May 26, 2024
src/lifecycle/paths.h
Outdated
| @@ -65,8 +65,19 @@ static constexpr const char* GRAAL_NATIVE_IMAGE_FILE {IOS_GRAAL_NATIVE_IMAGE_FIL | |||
|
|
|||
| #endif | |||
|
|
|||
| #ifdef X11_ENABLED | |||
There was a problem hiding this comment.
The else statement doesn't make sense to have anymore.
Also I would simply make all those paths not unique to an OS because if you want to go the extra mile, it should be possible to do cross platform exports ( For example exporting for Linux on a Windows editor).
I recommend doing like I did with all the other paths above, with the specialised path available to everyone, and then a preprocessor that pick the one specific to your system. That way, you can freely use the right path in the export plugin.
chippmann
force-pushed
the
feature/jre-folder-per-platform-and-arch
branch
from
96984d5
to
d51d4b9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes the jre folder platform dependent.
This makes it possible for a project to have multiple jre folder simultaneously on the file system. The module then automatically picks the correct one for the current platform.
The main advantage of this is that on a project with multiple people working on it, the embedded jre can be committed to the repository for each platform together with the built jar and a project member does not need to have java locally installed and JAVA_HOME set. Which is especially useful if one is working with non programmers.
Note: Breaking change. Needs special notes in release notes!