Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add recursive interpolate #2234

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

leoferreiralima
Copy link

@leoferreiralima leoferreiralima commented May 3, 2024

fixes #2227

Description

Add option to compose env variables with recursion

image Captura de tela 2024-05-03 174552 Captura de tela 2024-05-03 174604 Captura de tela 2024-05-03 174616 Captura de tela 2024-05-03 174654 Captura de tela 2024-05-03 174704

Contribution Checklist:

  • The pull request only addresses one issue or adds one feature.
  • The pull request does not introduce any breaking changes
  • I have added screenshots or gifs to help explain the change if applicable.
  • I have read the contribution guidelines.
  • Create an issue and link to the pull request.

Note: Keeping the PR small and focused helps make it easier to review and merge. If you have multiple changes you want to make, please consider submitting them as separate pull requests.

Publishing to New Package Managers

Please see here for more information.

Copy link

@jeremygau jeremygau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm
Just the test to update

Copy link

@jeremygau jeremygau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is no tests for duplicated variable in input string. Is that behaviour a bug or a feature ?

@leoferreiralima
Copy link
Author

There is no tests for duplicated variable in input string. Is that behaviour a bug or a feature ?

I don't see why I can't have 'VAR1={{VAR2}} {{VAR2}}'

I will write a test for this case to cover this

@leoferreiralima
Copy link
Author

leoferreiralima commented May 4, 2024

There is no tests for duplicated variable in input string. Is that behaviour a bug or a feature ?

I don't see why I can't have 'VAR1={{VAR2}} {{VAR2}}'

I will write a test for this case to cover this

@jeremygau fixed this too

image

Copy link

@jeremygau jeremygau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good
Good job @leoferreiralima
Thanks for implementing this feature
Hope it will be released soon

@leoferreiralima
Copy link
Author

Looks good Good job @leoferreiralima Thanks for implementing this feature Hope it will be released soon

Thanks @jeremygau, i expected this to be released soon too!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Environment variable in other environment variable
2 participants