Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: adjust code editor font size #2204

Open
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

krummbar
Copy link
Contributor

@krummbar krummbar commented Apr 30, 2024

Description

Fixes #1596

New

Adds a setting to configure the code editor font size. If unchanged it defaults to inherit mode.
Font size property is applied in following components

  • Request body editor
  • Script editor
  • Tests editor
  • Docs (edit-mode)
  • GraphQL Query editor
  • GraphQL Variables editor
  • Generated Code

bruno-pr2204-preferences

bruno-pr2204-font-size-change.mp4

Fix

Fixes font-family not being applied to GraphQL query editor.

Before
https://github.com/usebruno/bruno/assets/1665841/60294e21-1128-47dc-8404-77a23ea74e0c

After
https://github.com/usebruno/bruno/assets/1665841/c4792ca3-6af6-4caf-b428-a4baccaf9bba


Contribution Checklist:

  • The pull request only addresses one issue or adds one feature.
    While working on this, I found out that font-family change is not applied to GraphQL requests. Since this is only a minor change I included this as well. Let me know if I should create a separate PR for this.
  • The pull request does not introduce any breaking changes
  • I have added screenshots or gifs to help explain the change if applicable.
  • I have read the contribution guidelines.
  • Create an issue and link to the pull request.

@krummbar krummbar force-pushed the feat/code-editor-font-size branch from 23ee4bf to 40d6b64 Compare May 1, 2024 06:08
@busy-panda
Copy link

I've tested locally, that works.
Thanks for it @krummbar

@krummbar krummbar marked this pull request as ready for review May 1, 2024 08:55
@krummbar krummbar force-pushed the feat/code-editor-font-size branch from af5c4e1 to 00aa023 Compare May 7, 2024 19:15
@krummbar krummbar force-pushed the feat/code-editor-font-size branch from 00aa023 to d8ba993 Compare May 7, 2024 19:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[feature] I would like it to be possible to change the font size in the payload and output editors
2 participants