fix(preset-mini): transform-cpu should not include rotate-x and rotate-y
#3813
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The class name `transform-cpu` does not achieve the expected effect because `rotateX()` and `rotateY()` cause the browser to use gpu rendering.
✅ Deploy Preview for unocss ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
antfu
approved these changes
May 16, 2024
antfu
changed the title
transform-cpu should not include rotate-x and rotate-y
antfu
approved these changes
Jun 11, 2024
Simon-He95
pushed a commit
to Simon-He95/unocss
that referenced
this pull request
Jun 12, 2024
Simon-He95
pushed a commit
to Simon-He95/unocss
that referenced
this pull request
Jun 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The class name
transform-cpudoes not achieve the expected effect becauserotateX()androtateY()cause the browser to use gpu rendering.There is an example created by stackblitz, demonstrating the difference when an svg icon is rendered using cpu rendering versus gpu rendering in Chrome. The difference will not be shown in "Open Preview" but will be shown in "Open Preview in new tab":
Enabling the
Layer bordersoption in theRenderingtab of Chrome’s DevTools allows for better observation of the differences between them: