optlib: allow users to set fields and check extras defined in a foreign language #3960
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #3960 +/- ##
==========================================
+ Coverage 85.38% 85.40% +0.01%
==========================================
Files 235 235
Lines 56543 56648 +105
==========================================
+ Hits 48282 48379 +97
- Misses 8261 8269 +8 ☔ View full report in Codecov by Sentry. |
masatake
force-pushed
the
main--foreign-fields
branch
from
889673f
to
e14c4e6
Compare
…ct order Signed-off-by: Masatake YAMATO <[email protected]>
…xtra or field name Signed-off-by: Masatake YAMATO <[email protected]>
…for newly defined field Signed-off-by: Masatake YAMATO <[email protected]>
--_list-fielddef-flags option is added, too. Signed-off-by: Masatake YAMATO <[email protected]>
…ng _field regex flag
The original code assumed the parser specified in a regex pattern
was the owner of the field specified with the _field regex flag in
the pattern.
For an example, in the option
--regex-Foo=/.../{_field=afield:\1}...
, ctags assumed "afield" was a specific field of "Foo" parser.
The original code didn't consider an option like
--regex-Foo=/.../{_language=Bar}{_field=afield:\1}...
In this case, ctags should consider "afield" as a specific
field of "Bar" parser.
NOTE: the language specified with _language flag must be
declared with _foreignLanguage= in --langdef-Foo.
Signed-off-by: Masatake YAMATO <[email protected]>
…field setters This is a preparation. A test case for raising the error introduced in this commit will be added when we have real field accessors. Signed-off-by: Masatake YAMATO <[email protected]>
The operators (setter and/or getter) for each field. The name of operatos has following form: setter => :<LANG>.<FIELD> getter => <LANG>.<FIELD>: NOTE: The operators for a field are defined only if the field has C level getters and setters, getValueObject and setValueObject in fieldDefinition. This commit doesn't provide a getter and a setter. The test cases and the real accessor will be implemented later. Signed-off-by: Masatake YAMATO <[email protected]>
…ned in an optlib parser Signed-off-by: Masatake YAMATO <[email protected]>
…xtra regex flag
The original code assumed the parser specified in a regex pattern
was the owner of the extra specified with the _extra regex flag in
the pattern.
For an example, in the option
--regex-Foo=/.../{_extra=anextra}...
, ctags assumed "anextra" was a specific extra of "Foo" parser.
The original code didn't consider an option like
--regex-Foo=/.../{_language=Bar}{_extra=anextra}...
In this case, ctags should consider "anextra" as a specific
extra of "Bar" parser.
NOTE: the language specified with _language flag must be
declared with _foreignLanguage= in --langdef-Foo.
Signed-off-by: Masatake YAMATO <[email protected]>
Signed-off-by: Masatake YAMATO <[email protected]>
masatake
force-pushed
the
main--foreign-fields
branch
from
e14c4e6
to
cbdc8c8
Compare
|
The ways to support boolean fields are not consistent in various aspects. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In addition, this pull request allows you to fill out a field for a foreign tag from optscript.