Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/ Adding sample weight #2362

Closed
wants to merge 22 commits into from
Closed

Conversation

AntonRagot
Copy link
Contributor

Checklist before merging this PR:

  • Mentioned all issues that this PR fixes or addresses.
  • Summarized the updates of this PR under Summary.
  • Added an entry under Unreleased in the Changelog.

Fixes #1175.

Summary

  • Adding the option to choose between three possibilities of predefined weights
  • fit now has the option to support sample_weight, which can be a string or a TimeSeries

Copy link

codecov bot commented May 10, 2024

Codecov Report

Attention: Patch coverage is 78.57143% with 9 lines in your changes are missing coverage. Please review.

Project coverage is 93.67%. Comparing base (e2085ae) to head (c6395e8).

Files Patch % Lines
darts/utils/timeseries_generation.py 22.22% 7 Missing ⚠️
darts/models/forecasting/regression_model.py 90.90% 1 Missing ⚠️
darts/utils/data/tabularization.py 95.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2362      +/-   ##
==========================================
- Coverage   93.73%   93.67%   -0.06%     
==========================================
  Files         138      138              
  Lines       14309    14330      +21     
==========================================
+ Hits        13412    13424      +12     
- Misses        897      906       +9     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dennisbader dennisbader mentioned this pull request Jun 5, 2024
3 tasks
@dennisbader
Copy link
Collaborator

Closing as covered in #2404

@dennisbader dennisbader closed this Jun 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Easy Sample Weights
3 participants