Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add
Pattern Bytes
Overview
add support for constructing
Pattern
s overBytes
Implementation notes
Genericized
Pattern
andCPattern
.Pattern
now takes two type parameters, one is the type likeBytes
orText
and one is the type which is going to contain all the character class like things, right now it isCharPattern
which lets you do things like "range" and "set" and "not" and "any". bytes will be largely similar.Interesting/controversial decisions
Test coverage
not yet
Loose ends
TBD