Re-enable isort and run on codebase #1295
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At the moment, isort isn't running because of the
--diff
option which effectively turns it into a print-only tool. The pre-commit doesn't actually print anything though, and it doesn't raise any exit code so the pre-commit, CI etc. will pass even when the tool thinks things are unsorted.Similar to #1292, I suggest moving the configuration out of the pre-commit config file (and also setup.cfg) and into pyproject.toml.
I've run isort across the entire codebase, so a lot of files have changed (only cosmetically, of course).