Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UTS46 test data fixes for 175-A88 #824

Merged
merged 3 commits into from
May 20, 2024

Conversation

markusicu
Copy link
Member

@markusicu markusicu commented May 17, 2024

For https://github.com/unicode-org/properties/issues/162

which contains discussion for
[175-A88] Action Item for Mark Davis, PAG: Review IdnaTestV2.txt and ensure that the documentation and output of status codes conforms to the specification; see L2/23-079 item 6.3 for a report of mismatches; for Unicode Version 15.1.

Review one commit at a time.

Changes, in the order of the bug report items:

  • P4: fixed header comment
  • in-browser-test-friendly: avoid the last label consisting of only ASCII digits (second commit)
  • U1 not V7 if disallowed_STD3_* (third commit)
  • NV8: Updated header comment, copied from issue with minor changes
  • A3: Added a test case that triggers it (unpaired surrogate), and a header comment that it can be filtered out
  • X3:
    • The implementation "knows about it" but it's unreachable code
    • Added a code comment
    • Updated header comment, copied from issue but simplified it
  • "CheckBidi is not V8" was already fixed in an earlier PR

@markusicu markusicu marked this pull request as ready for review May 18, 2024 00:08
@markusicu
Copy link
Member Author

Thanks Josh! @macchiati ok to merge?

@markusicu markusicu merged commit ed0f8f9 into unicode-org:main May 20, 2024
31 checks passed
@markusicu markusicu deleted the idnatest-175-A88 branch May 20, 2024 18:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants