Implement Extended Currency DataModel

[younies]

No description provided.

[sffc]

Suggestion: I think in general the best way to store things that vary by plural form is to pull out the other variant and store all the others in the map. Something more like

/// For plural form 'other'
pub pattern_config_other: CurrencyPatternConfig,
/// For all other plural forms and explicit forms
pub pattern_config_plurals: ZeroMap<'data, Count, CurrencyPatternConfig>,

This is good because

1. The fallback to other is infallible
2. In locales that don't use plurals (like CJK), the ZeroMap becomes empty, which is nice

[younies]

great idea, we treated it as default pattern.

[younies]

@sffc and @robertbastian

when I run cargo make testdata

I received the following error message

thread 'provider::tests::make_testdata::make_testdata' panicked at provider/datagen/src/provider/tests/make_testdata.rs:302:9:
Expected violations list does not match found violations!
If the new list is smaller, please update EXPECTED_VIOLATIONS in make-testdata.rs
If it is bigger and that was unexpected, please make sure the key remains zero-copy, or ask ICU4X team members if it is okayto temporarily allow for this key to be allowlisted.
Expected:
[DataKey{datetime/skeletons@1}]
Found:
[DataKey{currency/extended@1}, DataKey{datetime/skeletons@1}]
Expected (transient):
[DataKey{list/and@1}, DataKey{list/or@1}, DataKey{list/unit@1}]
Found (transient):
[DataKey{list/and@1}, DataKey{list/or@1}, DataKey{list/unit@1}]

[sffc]

It means that DataKey{currency/extended@1} contains allocated data and you need to make it zero-copy.

[sffc]

It looks like you forgot to add #[cfg_attr(feature = "serde", serde(borrow))] on all of the fields. If you don't have that annotation, they always get deserialized as fully owned (allocated).

[younies]

It looks like you forgot to add #[cfg_attr(feature = "serde", serde(borrow))] on all of the fields. If you don't have that annotation, they always get deserialized as fully owned (allocated).

@sffc : thanks for the notice, but even I applied this, still I get the same message

Expected violations list does not match found violations!
If the new list is smaller, please update EXPECTED_VIOLATIONS in make-testdata.rs
If it is bigger and that was unexpected, please make sure the key remains zero-copy, or ask ICU4X team members if it is okayto temporarily allow for this key to be allowlisted.
Expected:
[DataKey{datetime/skeletons@1}]
Found:
[DataKey{currency/extended@1}, DataKey{datetime/skeletons@1}]
Expected (transient):
[DataKey{list/and@1}, DataKey{list/or@1}, DataKey{list/unit@1}]
Found (transient):
[DataKey{list/and@1}, DataKey{list/or@1}, DataKey{list/unit@1}]

[robertbastian]

Serde is too limited to borrow through an Option, you need to use one of the methods in provider/core/src/serde/borrow_de_utils.rs

[sffc]

serde-rs/serde#2016 again

[robertbastian]

Wow they locked that thread.

[sffc]

Since the Serde issue doesn't keep track of linked issues any more, let's start using #1556 to keep track of all the cases where we've wasted time re-discovering and re-working-around this issue (which I still hold to be fully in scope for Serde core)

[younies]

right now, I added those fields to the display_names map in order to avoid this :)

actually, this will reduce the datasize by replacing the none case with empty.

[sffc]

This looks good, but I would like to see a way to reduce the number of currency JSON files generated in testdata if possible? Thoughts @robertbastian?