Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ICU-22001 Put translation unit local definitions in unnamed namespaces #2982

Merged
merged 1 commit into from
May 30, 2024

Conversation

roubert
Copy link
Member

@roubert roubert commented Apr 24, 2024

Any symbol that isn't intended to have external linkage should either be declared static (legacy code) or put in an unnamed namespace.

Checklist
  • Required: Issue filed: https://unicode-org.atlassian.net/browse/ICU-22001
  • Required: The PR title must be prefixed with a JIRA Issue number.
  • Required: The PR description must include the link to the Jira Issue, for example by completing the URL in the first checklist item
  • Required: Each commit message must be prefixed with a JIRA Issue number.
  • Issue accepted (done by Technical Committee after discussion)
  • Tests included, if applicable
  • API docs and/or User Guide docs changed or added, if applicable

Any symbol that isn't intended to have external linkage should either be
declared static (legacy code) or put in an unnamed namespace.
@roubert
Copy link
Member Author

roubert commented May 29, 2024

Ping?

@roubert roubert merged commit edfe255 into unicode-org:main May 30, 2024
97 checks passed
@roubert roubert deleted the 22001 branch May 30, 2024 12:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants