Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check null after malloc() and define trivial destructor C++11 #3809

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Check null after malloc() and define trivial destructor C++11 #3809

wants to merge 1 commit into from

Conversation

GermanAizek
Copy link

micheleCTDEAdmin
micheleCTDEAdmin requested changes Aug 19, 2022
View reviewed changes
Copy link
Collaborator

@micheleCTDEAdmin micheleCTDEAdmin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please amend as commented.

src/compat_win32.cpp
}
else
{
return(false);
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we should make sure 'str' is an empty string in this case, since now it would not be updated if we go through the else part.

@micheleCTDEAdmin
Copy link
Collaborator

Also this PR is failing the automatic checks. Please fix them too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@micheleCTDEAdmin micheleCTDEAdmin micheleCTDEAdmin requested changes

@gmaurel gmaurel Awaiting requested review from gmaurel gmaurel is a code owner

@mwoehlke-kitware mwoehlke-kitware Awaiting requested review from mwoehlke-kitware mwoehlke-kitware is a code owner

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@GermanAizek @micheleCTDEAdmin