Fix the editor UI alias migration and re-run it #16292
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prerequisites
Description
The editor UI alias migration is flawed - it does not run unless there are custom property editors in the source (V13) database. The result is that a default V13 database is upgraded to V14 with no editor UI aliases, which causes havoc in the UI.
This PR ensures that the migration always runs.
As the flawed migration has already run on RC3, I have opted to re-run it during upgrade. Other than potential duplicate warning messages for any misconfigured/missing data types, it is entirely harmless to run the migration twice (in all likelihood there will be no warnings).
Testing this PR
Create a blank V13 site and migrate it to V14. The data types should be migrated to have the correct editor UI aliases; if the data type icons show correctly in V14, the migration worked as it should.