Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[V14] import/export media/document type endpoints #16100

Merged
merged 13 commits into from
May 17, 2024
Merged

[V14] import/export media/document type endpoints #16100

merged 13 commits into from
May 17, 2024

Conversation

Migaroez
Copy link
Contributor

@Migaroez Migaroez commented Apr 18, 2024 •
edited

Prerequisites

  • I have added steps to test this contribution in the description below

Description

This adds the import/export functionality of v13 and below into the management API. The main differences being:

  • Upload/import have been split using the the temporary import file endpoint as other similar file handling endpoints
  • The responsibility of extracting partial information has been moved to the backend
  • It is no longer possible to import a content type as a media type or the other way around.

Testing

  • the analyse endpoint should give enough information about an uploaded file to display similar information in the new backoffice as in the old before confirming the import
  • Exporting a content type / mediatype in v14 should give the same result as v13
  • the 4 import endpoints (media/document + POST/PUT) endpoints all behave logically. Check ContentTypeImportOperationStatusResult() & MediaTypeImportOperationStatusResult() for inspiration.
  • It should be possible to import types into v14 from files exported in v13

@Migaroez Migaroez added the project/bellissima AKA "the new backoffice" label Apr 18, 2024
Sven Geusens added 4 commits April 22, 2024 10:29
WIP
550504c
Refactoring of import doctype/media types
ee4046d 
- added analyze endpoint to extract relevant data without fully processing the file
- split up import endpoints into POST & PUT
- removed availableAtAction as the new endpoint allows clients to call the POST/PUT endpoints with confidence
- Added a new service that is responsible for turning temp files into Import compatible XML and being able to extracty partial information from it
Merge branch 'v14/dev' into v14/feature/import-export-types
67151de 
# Conflicts:
#	src/Umbraco.Cms.Api.Management/DependencyInjection/UmbracoBuilderExtensions.cs
#	src/Umbraco.Core/DependencyInjection/UmbracoBuilder.cs
Wrap persistance access in scopes
9c69ea9
@Migaroez Migaroez marked this pull request as ready for review May 6, 2024 12:04
@kjac
Copy link
Contributor

kjac commented May 6, 2024

I have pushed a little bit of clean-up and pedantic formatting 🙈 and there are a few comments you can look at.

Also, I think the OpenAPI.json file needs regenerating to contain the new APIs?

@Migaroez
Copy link
Contributor Author

Frontend implementation of this will be after 14.0.0

@Migaroez Migaroez merged commit 80794f3 into v14/dev May 17, 2024
14 of 15 checks passed
@Migaroez Migaroez deleted the v14/feature/import-export-types branch May 17, 2024 12:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kjac kjac kjac approved these changes

Assignees
No one assigned
Labels
project/bellissima AKA "the new backoffice"
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Migaroez @kjac