Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support using absolute urls when domain is matched and mode is auto. #16005

Open
wants to merge 1 commit into
base: contrib
Choose a base branch
from

Conversation

nzdev
Copy link
Contributor

@nzdev nzdev commented Apr 8, 2024

Prerequisites

  • I have added steps to test this contribution in the description below

If there's an existing issue for this PR then this fixes

Description

What?
Optionally allow the DefaultUrlProvider to return Absolute Url's when the domain matches and UrlMode.Auto.
Keep behaviour using UrlMode.Auto to return Relative Urls from DefaultUrlProvider when the domain does not match.

Why?
I'd like to return a relative url when the current request domain does not match the domain assigned to the node / it's ancestor, and a Absolute Url if it matches.

How to test?
Updated relevant test cases in pr.
Adds option UseAbsoluteUrlForAutoWhenDomainMatches to RequestHandler settings to enable.

Copy link

github-actions bot commented Apr 8, 2024

Hi there @nzdev, thank you for this contribution! 👍

While we wait for one of the Core Collaborators team to have a look at your work, we wanted to let you know about that we have a checklist for some of the things we will consider during review:

  • It's clear what problem this is solving, there's a connected issue or a description of what the changes do and how to test them
  • The automated tests all pass (see "Checks" tab on this PR)
  • The level of security for this contribution is the same or improved
  • The level of performance for this contribution is the same or improved
  • Avoids creating breaking changes; note that behavioral changes might also be perceived as breaking
  • If this is a new feature, Umbraco HQ provided guidance on the implementation beforehand
  • 💡 The contribution looks original and the contributor is presumably allowed to share it

Don't worry if you got something wrong. We like to think of a pull request as the start of a conversation, we're happy to provide guidance on improving your contribution.

If you realize that you might want to make some changes then you can do that by adding new commits to the branch you created for this work and pushing new commits. They should then automatically show up as updates to this pull request.

Thanks, from your friendly Umbraco GitHub bot 🤖 🙂

@mikecp
Copy link
Contributor

mikecp commented Apr 8, 2024

Hello @nzdev ,

Thanks for this update! A member of the core collaborators team will have a look at it soon. We might have to check with HQ about their feeling of adding an extra settings parameter along the way 😉

Cheers!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants