New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated data/utils.py and engine/validator.py #10206
base: main
Are you sure you want to change the base?
Conversation
I have read the CLA Document and I sign the CLA |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #10206 +/- ##
==========================================
- Coverage 77.88% 74.80% -3.08%
==========================================
Files 122 122
Lines 15579 15607 +28
==========================================
- Hits 12133 11675 -458
- Misses 3446 3932 +486
Flags with carried forward coverage won't be shown. Click here to find out more. โ View full report in Codecov by Sentry. |
Hi @glenn-jocher, I will look into the errors and try to resolve them. However, I need to ask a few things.
Thanks |
Also @glenn-jocher @Burhan-Q, pls review the PR and share your views about if it's correct or what changes can be made. |
Hi @glenn-jocher. My approach is that I check for the extension of the dataset and pass it in the Is this approach correct? Should I proceed with changing everywhere where |
Hi there! Your approach sounds solid for expanding dataset format support. ๐ Yes, you should proceed with modifying the necessary parts of the code that call |
Hi @glenn-jocher, please review the PR and let me know. |
Hi @glenn-jocher, can you please help with how to resolve this error? I am confused with this. |
Hi there! Sure, Iโd be happy to help. Could you please provide a bit more detail about the error youโre encountering? A snippet of the error message or the context around when it occurs would be really helpful for diagnosing the issue. Looking forward to assisting you! ๐ |
Hi, so I am encountering issues at 2 places.
if self.task == "classify":
unzip_dir = unzip_file(path)
data = check_cls_dataset(unzip_dir)
data["path"] = unzip_dir
else: # detect, segment, pose
_, data_dir, yaml_path = self._unzip(Path(path))
try:
# Load YAML with checks
data = yaml_load(yaml_path)
data["path"] = "" # strip path since YAML should be in dataset root for all HUB datasets
yaml_save(yaml_path, data)
data = check_det_dataset(yaml_path, ".yaml", autodownload) # dict
data["path"] = data_dir # YAML path should be set to '' (relative) or parent (absolute)
except Exception as e:
raise Exception("error/HUB/dataset_stats/init") from e In this I am encountering the issue on line Thanks |
Also, please let me know how can I check for CI errors on my vscode only and only push code which is clean and error free. Any helpful commands for that? |
Hi! For the changes youโve made:
For checking CI errors locally, you can rely on pre-commit hooks or run specific linting and testing commands based on the CI pipeline of the project. For instance, running At minimum, you should run Hope this helps! |
โฆ1/ultralytics into add_multiple_datasets
Hi @glenn-jocher, Can you please check and merge? |
@Bhavay-2001 hi there! ๐ Thanks for the heads up. I'll review the changes ASAP and get back to you with any feedback or proceed with merging if everything looks good. Appreciate your patience and contribution! ๐ |
Hi @glenn-jocher, any updates on the PR? |
Hi @Bhavay-2001! Thanks for checking in. I'm currently reviewing the PR and will provide feedback or approve it shortly. Hang tight! ๐ If thereโs anything specific youโd like to discuss or need help with in the meantime, feel free to let me know! |
Hi @glenn-jocher, any updates on PR? |
Hi there! ๐ We're currently reviewing the PR and will provide feedback or move forward with merging very soon. Thanks for your patience! If there's anything else you'd like to discuss in the meantime, feel free to reach out. ๐ |
Hi @glenn-jocher, any updates? |
@Bhavay-2001 hi there! ๐ We're actively reviewing the PR and will keep you updated. Thanks for your patience! If thereโs anything specific you need help with, feel free to let me know. ๐ |
PR for issue #9095.
Reviewers - @glenn-jocher @Burhan-Q
It's a draft PR but I will happy to alter it and make changes. Please review it and provide suggestions to improve.
Thanks
๐ ๏ธ PR Summary
Made with โค๏ธ by Ultralytics Actions
๐ Summary
Enhanced dataset handling now supports JSON in addition to YAML.
๐ Key Changes
extension
parameter tocheck_det_dataset
function to support JSON files..yaml
/.yml
and.json
formats for dataset descriptions.๐ฏ Purpose & Impact