Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update default.yaml to include the save_dir parameter. #10153

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Commits on Apr 18, 2024

  1. Update default.yaml to include the save_dir parameter.

    The goal of your commit is to address an issue encountered during validation, specifically related to the save_dir argument not utilizing the value passed to the function as intended. Instead, it utilizes an incremented path, leading to unexpected behavior.
    
    This issue stems from the get_cfg function, where the condition if "save_dir" not in cfg: sets save_dir to None if it's not already defined in the configuration. As a result, the intended value of save_dir passed to the function is not used, leading to the undesired behavior during validation.
    jbdebelle committed Apr 18, 2024
    Configuration menu
    Copy the full SHA
    04961a0 View commit details
    Browse the repository at this point in the history

Commits on Apr 21, 2024

  1. Configuration menu
    Copy the full SHA
    36ff582 View commit details
    Browse the repository at this point in the history

Commits on May 10, 2024

  1. Configuration menu
    Copy the full SHA
    4cd2df9 View commit details
    Browse the repository at this point in the history