Expose service IP and port as variables in service providers #1498
+68
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This replaces the
_serverNameSpace
with_serverIP
and_serverPort
._serverNameSpace
was used back in Orion when it was using named pipes. It is now using TCP and although LeapC still uses a variable calledserver_namespace
, it can be used to connect to a service listening on a different IP/port by passing a JSON payload containingtracking_server_ip
andtracking_server_port
:Contributor Tasks
breaking
to this MR.Reviewer Tasks
Add any instructions or tasks for the reviewer such as specific test considerations before this can be merged.
Use emojis in review threads to communicate intent and help contributors.
Closes JIRA Issue
Closes UNITY-1217