Skip to content

Commit

Permalink
* [Issue #1] Application crashes (immediately) after choosing ' View …
Browse files Browse the repository at this point in the history
…log' from the menu.

Addressed a couple of lint warnings.
  • Loading branch information
amaa-99 committed Aug 19, 2023
1 parent 80ffb7e commit f71e192
Showing 1 changed file with 5 additions and 7 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,6 @@
import static dev.ukanth.ufirewall.Api.TAG;

import android.content.Context;
import android.content.pm.PackageInfo;
import android.content.pm.PackageManager;
import android.graphics.drawable.Drawable;
import android.view.LayoutInflater;
Expand All @@ -12,6 +11,7 @@
import android.widget.ImageView;
import android.widget.TextView;

import androidx.annotation.NonNull;
import androidx.recyclerview.widget.RecyclerView;

import java.text.DateFormat;
Expand All @@ -29,10 +29,7 @@ public class LogRecyclerViewAdapter extends RecyclerView.Adapter<LogRecyclerView

private final List<LogData> logData;
private final Context context;
private LogData data;
private PackageInfo info;
private final RecyclerItemClickListener recyclerItemClickListener;
private View mView;

public LogRecyclerViewAdapter(final Context context, RecyclerItemClickListener recyclerItemClickListener) {
this.context = context;
Expand All @@ -45,9 +42,10 @@ public void updateData(List<LogData> logDataList) {
logData.addAll(logDataList);
}

@NonNull
@Override
public ViewHolder onCreateViewHolder(ViewGroup parent, int viewType) {
mView = LayoutInflater.from(parent.getContext()).inflate(R.layout.log_recycle_item, parent, false);
View mView = LayoutInflater.from(parent.getContext()).inflate(R.layout.log_recycle_item, parent, false);
return new ViewHolder(mView);
}

Expand Down Expand Up @@ -97,9 +95,9 @@ private Bitmap getAppIcon26(PackageManager mPackageManager, ApplicationInfo appl

@Override
public void onBindViewHolder(ViewHolder holder, int position) {
data = logData.get(position);
LogData data = logData.get(position);
PackageManager manager = context.getPackageManager();
holder.bind(logData.get(position),recyclerItemClickListener);
holder.bind(logData.get(position), recyclerItemClickListener);
try {
Drawable applicationIcon = Api.getApplicationIcon(context, data.getUid());
holder.icon.setBackground(applicationIcon);
Expand Down

0 comments on commit f71e192

Please sign in to comment.