Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow carousel to scroll on 0 velocity #58

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

PsychicCat
Copy link

As a user I would expect that I can swipe the carousel slowly and it would snap to the next tile when I stop the touch interaction. This allows us to support that by setting velocity: 0 in NguCarouselConfig.

@PsychicCat PsychicCat mentioned this pull request Jun 19, 2018
@pssubashps
Copy link

When we can expect this on master ?

@pkrawat1
Copy link

pkrawat1 commented Jul 28, 2018

Yup, @sheikalthaf when will this be merged into master. I'm using it on angularspree

@sheikalthaf
Copy link
Collaborator

@PsychicCat @pssubashps @pkrawat1 Hi,

I'm working on to update the carousel to angular 6. And also moving from ngFor to iterable differs similar to angular material tree. I will update my beta version and Please test it let me know your feedbacks

Thanks

@sheikalthaf
Copy link
Collaborator

@PsychicCat @pssubashps @pkrawat1 Anyone know how to handle Hammerjs in ng-packagr?

@pkrawat1
Copy link

pkrawat1 commented Jul 30, 2018

I have no experience with that. @sheikalthaf
By the way, why not use the hammer gesture right from angular 6 itself. I think they are providing gestures with hammer only after angular 6.
Also did some fixes in 6.1 recently. Hammer gesture in angular

Also today I released Angularspree Beta-1 with ngu-carousel. Thanks for this lib @sheikalthaf

@sheikalthaf
Copy link
Collaborator

@pkrawat1 Thanks for supporting. Next beta release will be a major one. Please test it and let me know your feedback

@sheikalthaf
Copy link
Collaborator

sheikalthaf commented Aug 2, 2018

@PsychicCat @pssubashps @pkrawat1 Hi all,

Published a build with angular 6 upgrade in beta. Please test and let me know your feedback.
Check this stackblitz link to know the breaking changes.

Once testing complete then i will move it to master

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants