Swipe touch - hammerjs replaced with contact-js #446
Conversation
arumuganainar73
commented
May 4, 2023
arumuganainar73
commented
- Removed hammerjs package from package json
- Replaced touch actions with contact js (https://biodiv.github.io/contactjs/)
| @@ -153,6 +149,8 @@ export class NguCarousel<T> | |||
|
|
|||
| private _destroy$ = new Subject<void>(); | |||
|
|
|||
| private _pointerListener: any; | |||
There was a problem hiding this comment.
Do we need this instance, if its not being used anywhere
| this._nguCarouselHammerManager.on(hammer, 'panup').subscribe((ev: any) => { | ||
| this._touchHandling('panleft', ev); | ||
| }); | ||
| this._pointerListener = new PointerListener(this._touchContainer.nativeElement, options); |
There was a problem hiding this comment.
Just to understand if this property is used to hold the reference, should er also unsubscribe to this listener onDestroy
| @@ -339,89 +336,79 @@ export class NguCarousel<T> | |||
| } | |||
|
|
|||
| ngOnDestroy() { | |||
| this._hammer?.destroy(); | |||
| this._destroy$.next(); | |||
| } | |||
|
|
|||
| /** Get Touch input */ | |||
| private _setupHammer(): void { | |||
There was a problem hiding this comment.
can we rename this method to _setupHammer -> setupTouch
☁️ Nx Cloud ReportCI is running/has finished running commands for commit c28a371. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this branch ✅ Successfully ran 1 targetSent with 💌 from NxCloud. |
|
can you add contactjs here https://github.com/uiuniversal/ngu-carousel/blob/master/libs/ngu/carousel/package.json#L8 and remove hammer, also remove all the reference to hammerjs and replace with contactjs |
done |
|
can you resolve the conflict please |
|
This PR has been automatically marked as stale because it has not had recent activity for 6 months. It will be closed if no further activity occurs. Thank you for your contributions. |
|
Closing this PR due to no activity for 6 months. |
