fix some issue #68
Open
fix some issue #68
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
First, I noticed that the .DS_Store files have been included in the PR. These are system files generated by macOS that we generally don’t need to track in our repository. A suggestion for the future would be add .DS_Store to our .gitignore file to prevent them from being committed in the future. Second, I noticed that there wasn’t much explanation in the PR description. It would be really helpful to have more context about the reasons behind these changes, especially since it's not immediately clear why this PR was created. 'fix some issue' doesn't ring a bell. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.