TLS enforcement and package refactoring #16
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi! Thank you for the PR! Sorry to take so long to reply! I am currently unable to merge it due to conflicts, can you have a look at them? |
to allow usage as a package from external golang projects. Full changes: - enforce TLS and full validation - made the code more testable - made it usable as a package (split the main to the cmd folder) - added end to end main unit test that launches a server and client - added Makefiles for common dev tasks - added cert generation for testing - refactored the config to provide defaults - moved config validation to the respective server and client code paths - added a bugfix to fix a crash when total duration <= 2 * update interval - changed docs to reflect the changes - moved the version to be an exported package property in config.go
peterhoneder
force-pushed
the
dev-tls-enforcement
branch
from
95e03e6
to
aec4342
Compare
Hi! sorry it took so long, but I rebased the PR and incorporated your latest changes to main.go since my initial PR into the other source files. This was necessary since the config logic moved to config.go. |
|
Merged, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit improves goben to be able to enforce TLS and refactors it to allow usage as a package from external golang projects.
Full changes:
Please let me know if you can consider this PR something to be merged upstream.