adds h5p server to materia stack, along with oauth changes for uploading media #1362
Conversation
…l necessary libraries during initial setup
…ignore in h5p/core and h5p/editor
h5p-server/renderers/player.js
Outdated
| switch (context) { | ||
| case "prod": | ||
| case "dev": | ||
| materiaPath = "https://localhost:8008"; |
There was a problem hiding this comment.
This url definitely shouldn't be hard-coded, but rather sourced from an env or other configuration. Doing so usually means pushing an inline variable definition in the fuel controller method that renders this content, via:
Js::push_inline('var BASE_URL = "'.Uri::base().'";');
Here's an example: https://github.com/ucfopen/Materia/blob/master/fuel/app/classes/controller/widgets.php#L519
h5p-server/express.js
Outdated
| // TODO replace whitelist with hosts from context env var | ||
| app.use( | ||
| cors({ | ||
| origin: [ |
There was a problem hiding this comment.
Same as previous comment - these URLs will have to come from a config somewhere.
| // return a new h5p widget | ||
| // used for materia to check for specific library | ||
| // should be deprecated as there is no need to save this information on the server | ||
| app.post("/new/:type", (req, res) => { |
There was a problem hiding this comment.
Is this section actually used? My understanding is we're not actually saving H5P content on the server - which I'm pretty sure was the original intent of the /new/ post request. I'm not sure if Materia actually performs this request as the comment suggests.
Added H5P URL and exposed it to player js
…r/ directory, adds some forgotten .env variables for h5p to communicate with materia, and makes some updates to allow h5p to run as a standalone server
also closes #1356