Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rider IDE project model support #248

Open
wants to merge 37 commits into
base: main
Choose a base branch
from

Conversation

SmelJey
Copy link

@SmelJey SmelJey commented Feb 1, 2023

Add support for JetBrains Rider IDE project model:

  • Rider project files can be generated using the /rdjson option;
  • It will allow Rider to open Sharpmake C++ solutions using generated project files or directly via .sharpmake.cs script.

@jspelletier jspelletier changed the base branch from dev to main April 6, 2023 12:51
SmelJey added 29 commits July 4, 2023 12:59
… Add "Minimize" and "IgnoreDefaults" parameters.
…ild build commands, change Clean command to remove .pdb and .pch files
Map output CppLanguageStandard and PchAction to RiderJson values.
@tru
Copy link

tru commented Aug 11, 2023

Hi! Thanks for the PR! Can you explain a little more about the motivation for adding Rider directly to sharpmake instead of using some of the other project generators, we are under the impression that Rider can read visual studio project files already?

@DecoyRS
Copy link

DecoyRS commented Aug 16, 2023

Hello @tru
Unfortunately, there is no .vcxproj files support in MSBuild on non-WIndows platforms (eg macOS, Linux), and an ability to work across all the platforms is pretty crucial for Rider.

@tru
Copy link

tru commented Aug 16, 2023

Yeah that was the speculation we had in our latest maintainer meeting. We will go ahead and review this one as soon as we have time! Thanks for the reply.

@@ -11,6 +11,7 @@ public static class CppLanguageStandard
{
public const string Cpp14 = "Cpp14";
public const string Cpp17 = "Cpp17";
public const string Cpp20 = "Cpp20";
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you break out this change and submit a small PR with just this change? That one we can merge directly and doesn't have to be part of the Rider one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants