Download the default boot image in host setup #1578
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pykello
force-pushed
the
pykello/vmsetup_images
branch
2 times, most recently
from
508c213
to
b5daf77
Compare
pykello
force-pushed
the
pykello/vmsetup_images
branch
from
b5daf77
to
5fd0c8c
Compare
enescakir
reviewed
May 12, 2024
enescakir
reviewed
May 13, 2024
prog/vm/host_nexus.rb
Outdated
| end | ||
| donate | ||
| end | ||
|
|
||
| label def download_boot_image | ||
| bud Prog::DownloadBootImage, {"image_name" => Config.default_boot_image_name, "version" => Config.default_boot_image_version} |
There was a problem hiding this comment.
@fdr expressed concerns about automatically downloading images during development previously in the one of @furkansahin PRs.
#772 (comment)
There was a problem hiding this comment.
What do you think about #1597?
pykello
force-pushed
the
pykello/image_cert
branch
from
b8764e8
to
636b77c
Compare
pykello
force-pushed
the
pykello/vmsetup_images
branch
from
5fd0c8c
to
b3706cd
Compare
pykello
force-pushed
the
pykello/image_cert
branch
from
636b77c
to
11b9689
Compare
pykello
force-pushed
the
pykello/vmsetup_images
branch
from
b3706cd
to
eeb220a
Compare
Since clover is going to only allocate boot images that have already been downloaded to storage volumes, we need at least one boot image when host setup finishes. This commit downloads the default boot image (configurable, currently ubuntu-jammy) when setting up the host.
Since clover is going to only allocate boot images that have already been downloaded before, and since we already download the default boot image on host setup, we don't need image download in vm_setup.
pykello
force-pushed
the
pykello/vmsetup_images
branch
from
eeb220a
to
feb492c
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
UPDATE: Alternatively, we can merge #1597
Since clover is going to only allocate boot images that have already been downloaded to storage volumes, we need at least one boot image when host setup finishes. This commit downloads the default boot image (configurable, currently ubuntu-jammy) when setting up the host.
In addition, we don't need image download in vm_setup. So, we remove it.