Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed camel case typo for uiviewController in ViewControllable & Issue regarding building the project #365

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

CosmicYogi
Copy link

Description:

  • If you download the project and try to build it or any of the tutorials you won't be able to do because of RxSwift.
  • In ViewControllable there is a property uiviewController which had been renamed to uiViewController in the entire project.

Related issue(s):

@CosmicYogi
Copy link
Author

When creating the commits for this PR my laptop was not setup with git configurations with author name and email address.
Is there any solution for CLA to get passed?

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.


Mitesh Soni seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

@jbarr21 jbarr21 added the iOS iOS related tickets label Jul 9, 2021
@ElonPark
Copy link
Contributor

@CosmicYogi
If your commits are linked to another user, that means the email address in your local Git configuration settings is connected to that user's account on GitHub. In this case, you can change the email in your local Git configuration settings and add the new email address to your account on GitHub.com account to link future commits to your account.

  1. To change the email address in your local Git configuration, follow the steps in "Setting your commit email address". If you work on multiple machines, you will need to change this setting on each one.

  2. Add the email address from step 2 to your account settings by following the steps in "Adding an email address to your GitHub account".

https://help.github.com/articles/why-are-my-commits-linked-to-the-wrong-user/#commits-are-not-linked-to-any-user

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
iOS iOS related tickets
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants