Skip to content
This repository has been archived by the owner on May 4, 2021. It is now read-only.

makisu pull: add support for --registry-config #359

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

lbpdt
Copy link

@lbpdt lbpdt commented Mar 11, 2021

This is useful to authenticate with the registry when pulling images.

@CLAassistant
Copy link

CLAassistant commented Mar 11, 2021

CLA assistant check
All committers have signed the CLA.

@lbpdt lbpdt force-pushed the feature/push-cmd-registry-config branch from aad9b0f to 8e8ccd4 Compare March 11, 2021 13:47
@lbpdt
Copy link
Author

lbpdt commented Mar 12, 2021

Hi @sema, would you be able to review this feature?

Also, it looks like the Fossa check on Travis has been failing for the past couple months, if that's something you can fix.

TROUBLESHOOTING: A FOSSA API key is needed to run this command.

Copy link
Collaborator

@sema sema left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding this!

bin/makisu/cmd/pull.go Outdated Show resolved Hide resolved
@bburky
Copy link

bburky commented Mar 15, 2021

I implemented something similar in #354. It also seemed that deleting the DockerHubRegistry code was needed to allow pulling from docker.io. The rest of makisu only allows configuration with --registry-config and doesn't have hardcoded docker config at all.

It's a little confusing to leave the hardcoded docker.io config if this registry-config option is added, because it cannot be overridden (I think so at least).

@lbpdt lbpdt force-pushed the feature/push-cmd-registry-config branch from 8e8ccd4 to 470bc53 Compare March 16, 2021 12:16
@lbpdt
Copy link
Author

lbpdt commented Mar 16, 2021

@bburky yours is very similar indeed, but with a larger scope than what I'm doing here. You could also rebase your PR on top of master if this one is merged first, so your change can be narrowly focussed on updating the hardcoded docker.io registry.

@lbpdt
Copy link
Author

lbpdt commented Mar 16, 2021

Build is now failing due to rate limiting on DockerHub. I'll kick it again is a couple hours.

library/golang
toomanyrequests: You have reached your pull rate limit. You may increase the limit by authenticating and upgrading: https://www.docker.com/increase-rate-limit

EDIT: build now passes but the Fossa check is still missing an API key...

This is useful to authenticate with the registry when pulling images.
@lbpdt lbpdt force-pushed the feature/push-cmd-registry-config branch from 470bc53 to 7c79732 Compare March 16, 2021 14:02
@lbpdt lbpdt requested a review from sema March 16, 2021 14:24
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants