Bring feature_asyncwebserver up to date with master #1475
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…zapu#1344)" This reverts commit 9f6dcad.
so it has nothing to do with the html , and can have different encoding, we could also just use IDs but scan cannot change, or use bssid tzapu#1370
any webserver event handlers bound before the webserver new reset would cause memory access issues when triggered. Should remove all events on reset or make memory safe, not sure if this is the correct way to be reseting the webserver, but there were issues with the ports not releasing etc.
This will avoid support inquiries and add a log
|
Brought feature_async up to date again as of where master stood an hour ago. The example that is failing to compile is one that explicitly overrides |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR brings feature_asyncwebserver up to date with master, and also gets the branch to a point where most of the tests compile.
Although there is a lot of work left to get this branch to the point where it could be incorporated back into master (setting async features behind feature flags, for example) this will hopefully make that process slightly easier.