Set default value of raw.theme
to auto
, and allow setting raw.theme
to auto
#4186
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pr closes #4182 .
I found out the bug in
parse_theme
. The functionparse_theme
always wants to parse the argumenttheme
intoEcoString
, which raises error when meetingnone
.As #4186 (review) , we set default value of
raw.theme
toauto
, and allow settingraw.theme
toauto
. To implement it, I redesigned the function signature (return value type):Err(...)
indicates argumenttheme
found but error met when casting it intoSmart<EcoString>
;Ok((None, None))
indicates argumenttheme
not found;Ok((Some(Smart::Auto), None))
indicates argumenttheme
found, and it isauto
;Ok((Some(Smart::Custom(path)), Some(data)))
indicates argumenttheme
found, and it isstr
(path to the theme file).