Fix comments swapped by mistake, and other nits #4055
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fix comments on the
mainandcrossaxis component that were swapped by mistake.In addition, this PR has these technically-unnecessary-but-subjectively-useful edits:
GentoGenericSizeto better express its meaning.gentogeneric_sizeto align with the type name and also to avoid the forthcoming keywordgenin the Rust 2024 edition.Renamed(reverted according to a review comment)StackLayouter.usedtoStackLayouter.sizeto better express its meaning - we want to emphasize the field stores a "size", instead of emphasizing "used", which sounds like a hash map for deduplication.