Implement under/over parens/shells, refactor code #3869
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
frozolotl
added a commit
to frozolotl/typst
that referenced
this pull request
Apr 4, 2024
See typst#3869 for reasoning.
frozolotl
added a commit
to frozolotl/typst
that referenced
this pull request
Apr 4, 2024
See typst#3869 for reasoning.
Merged
frozolotl
added a commit
to frozolotl/typst
that referenced
this pull request
Apr 4, 2024
See typst#3869 for reasoning.
frozolotl
force-pushed
the
push-lnotrxnworsq
branch
from
a044f18
to
6a8f1d2
Compare
I decided to use the word `shell` instead of turtle or tortoise because I think it is a bit clearer, the word reads nicer (“overshell” vs “overturtle”), and there is no associated discussion (they are called “tortoise shells” in Unicode): > tortoises and turtles are not the same thing! ~ @Enivex There will be a sibling PR to rename the symbols too. Additionally, I refactored some code to make it more readable. I also fixed a bug introduced in typst#3262 where the wrong script style was being used. Closes typst#3856.
frozolotl
force-pushed
the
push-lnotrxnworsq
branch
from
6a8f1d2
to
394f5aa
Compare
laurmaedje
reviewed
Apr 8, 2024
| let (above_style, below_style); | ||
| let annot_styles = match position { | ||
| Position::Above => { | ||
| above_style = style_for_subscript(styles); |
There was a problem hiding this comment.
If the annotation is above, it should use superscript style, if it is below, it should use subscript style.
| } else { | ||
| sub_style = style_for_subscript(styles); | ||
| styles.chain(&sub_style) | ||
| let baseline = match position { |
There was a problem hiding this comment.
I think, at the cost of duplicating the ctx.layout_into_run(annotation, annot_styles)?, we could put everything into one match and simplify things a bit. no need to do the let (above_style, below_style); lifetime dance and we can use insert directly rather than reverse.
|
Closing due to inactivity. Feel free to reopen if you still want to work on this! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I decided to use the word
shellinstead of turtle or tortoise because I think it is a bit clearer, the word reads nicer (“overshell” vs “overturtle”), and there is no associated discussion (they are called “tortoise shells” in Unicode):There will be a sibling PR to rename the symbols too.
Additionally, I refactored some code to make it more readable.
I also fixed a bug introduced in #3262 where the wrong script style was being used.
Closes #3856.