Use minus for pagination when watching
#3642
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I have merged #3648 for 0.11 because this feels a bit too dangerous to add post-RC (with the amount of new code and new dependencies introduced). Let's proceed with this after the release and ship the alternate screen in 0.12 instead! |
|
Closing due to inactivity. Feel free to reopen if you still want to work on this! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes the home-grown machinery for showing the
typst watchoutput and uses theminuspager instead.That especially means scrolling the output is now possible.
I also added a new
--pageroption that behaves similarly to--color.By default, the pager is only used for watching and when colors are enabled (implicitly or explicitly). Depending on preferences, users can use
--pager=alwaysor--pager=never.With this PR, there is now a bar with the command displayed at the bottom:
It could be disabled via
minus::Pager::show_prompt, but there is a slight display bug in that case, so I embraced it and put the entire command there.Fixes #3613.