Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(rule-tester): check for parsing errors in suggestion fixes #9052

Open
wants to merge 11 commits into
base: main
Choose a base branch
from

Conversation

abrahamguo
Copy link
Contributor

@abrahamguo abrahamguo commented May 6, 2024

PR Checklist

Overview

Check for parsing errors in suggestion fixes. Ported from ESLint; see eslint/eslint#16639

@typescript-eslint
Copy link
Contributor

Thanks for the PR, @abrahamguo!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!


🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

Copy link

netlify bot commented May 6, 2024

Deploy Preview for typescript-eslint ready!

Name Link
🔨 Latest commit a83ef1f
🔍 Latest deploy log https://app.netlify.com/sites/typescript-eslint/deploys/664358872df2bf000869d8e8
😎 Deploy Preview https://deploy-preview-9052--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 99 (🟢 up 1 from production)
Accessibility: 100 (no change from production)
Best Practices: 92 (no change from production)
SEO: 98 (no change from production)
PWA: 80 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@abrahamguo abrahamguo changed the title enhancement(rule-tester): check for parsing errors in suggestion fixes feat(rule-tester): check for parsing errors in suggestion fixes May 6, 2024
@kirkwaiblinger
Copy link
Member

LGTM!
FYI, I modified the description to include a link to the ESLint reference PR.
seal of approval

kirkwaiblinger
kirkwaiblinger previously approved these changes May 6, 2024
@kirkwaiblinger kirkwaiblinger added the 1 approval PR that a maintainer has LGTM'd - any maintainer can merge this when ready label May 6, 2024
Copy link
Member

@auvred auvred left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@auvred auvred added the awaiting response Issues waiting for a reply from the OP or another party label May 6, 2024
@github-actions github-actions bot removed the awaiting response Issues waiting for a reply from the OP or another party label May 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1 approval PR that a maintainer has LGTM'd - any maintainer can merge this when ready
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enhancement(rule-tester): check for parsing errors in suggestion fixes
3 participants