Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(eslint-plugin): [explicit-function-return-types] fix false positive on default parameters #9045

Conversation

kirkwaiblinger
Copy link
Member

PR Checklist

Overview

Adds default parameter check analogous to ordinary assignment.

…tation is present should count as typed function expressions

fix typescript-eslint#8950
@typescript-eslint
Copy link
Contributor

Thanks for the PR, @kirkwaiblinger!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!


🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

Copy link

netlify bot commented May 4, 2024

Deploy Preview for typescript-eslint ready!

Name Link
🔨 Latest commit cc97e0f
🔍 Latest deploy log https://app.netlify.com/sites/typescript-eslint/deploys/6641c6fc322c5c000871bc38
😎 Deploy Preview https://deploy-preview-9045--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 99 (🟢 up 3 from production)
Accessibility: 100 (no change from production)
Best Practices: 92 (no change from production)
SEO: 98 (no change from production)
PWA: 80 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@kirkwaiblinger kirkwaiblinger changed the title fix(eslint-plugin): [explicit-function-return-types] default parameters where a type annotation is present should count as typed function expressions fix(eslint-plugin): [explicit-function-return-types] fix false positive on default parameters May 4, 2024
@kirkwaiblinger kirkwaiblinger marked this pull request as ready for review May 4, 2024 17:27
@kirkwaiblinger kirkwaiblinger added the bug Something isn't working label May 4, 2024
Copy link
Member

@auvred auvred left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! 💯

@auvred auvred merged commit 8acb8d4 into typescript-eslint:main May 13, 2024
57 of 58 checks passed
@kirkwaiblinger kirkwaiblinger deleted the default-function-parameter-return-types branch May 13, 2024 15:57
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 21, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: [explicit-function-return-type] false positive on defaulting parameters
2 participants