New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(rule-tester): port checkDuplicateTestCases
from ESLint
#9026
base: main
Are you sure you want to change the base?
feat(rule-tester): port checkDuplicateTestCases
from ESLint
#9026
Conversation
Thanks for the PR, @abrahamguo! typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community. The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately. Thanks again! 🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. |
✅ Deploy Preview for typescript-eslint ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
@JoshuaKGoldberg should this be going into |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks for the port! 🙌
Just one suggestion on refactoring to a new file. If you don't like it I don't mind, and can merge as-is. Just let me know. 🙂
👍 Let's do |
@JoshuaKGoldberg one curiosity question — how is this port of |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
D'oh! Sorry, brain fart this morning - there should be tests. See packages/rule-tester/tests/eslint-base/eslint-base.test.js
.
There are about 10-20 rules in |
PR Checklist
Overview
Ports
checkDuplicateTestCases
from ESLint'sRuleTester
.