Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add @types/eslint__js to Quickstart.mdx #8939

Merged
merged 2 commits into from
May 27, 2024

Conversation

Tanavya
Copy link
Contributor

@Tanavya Tanavya commented Apr 17, 2024

Without this, I was getting an error Could not find a declaration file for module '@eslint/js'. In VS Code, in the following eslint.config.js from the Getting Started guide:

// @ts-check

import eslint from "@eslint/js";
import tseslint from "typescript-eslint";

export default tseslint.config(
  eslint.configs.recommended,
  ...tseslint.configs.recommended,
);

PR Checklist

Overview

@typescript-eslint
Copy link
Contributor

Thanks for the PR, @Tanavya!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!


🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

Copy link

netlify bot commented Apr 17, 2024

Deploy Preview for typescript-eslint ready!

Name Link
🔨 Latest commit bf16589
🔍 Latest deploy log https://app.netlify.com/sites/typescript-eslint/deploys/66547f857b7cd700093319ad
😎 Deploy Preview https://deploy-preview-8939--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 97 (🟢 up 5 from production)
Accessibility: 100 (no change from production)
Best Practices: 92 (no change from production)
SEO: 98 (no change from production)
PWA: 80 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Member

@JoshuaKGoldberg JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems reasonable to me. Though, we should also hear from @bradzacher who's done a lot here too. Thanks for sending!

@JoshuaKGoldberg JoshuaKGoldberg changed the title Update Quickstart.mdx docs: add @types/eslint__js to Quickstart.mdx May 26, 2024
bradzacher
bradzacher previously approved these changes May 26, 2024
@JoshuaKGoldberg JoshuaKGoldberg dismissed stale reviews from bradzacher and themself via bf16589 May 27, 2024 12:41
@JoshuaKGoldberg JoshuaKGoldberg merged commit 6e4acae into typescript-eslint:main May 27, 2024
61 of 62 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants