Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate ChatFragment to ViewPager2 #173

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Migrate ChatFragment to ViewPager2 #173

wants to merge 2 commits into from

Conversation

TacoTheDank
Copy link
Contributor

Brought over from #152

Separated into two PRs to prevent holdup of perfectly good activity viewpager2s.

@TacoTheDank TacoTheDank mentioned this pull request Dec 19, 2020
Merged
@TacoTheDank
Copy link
Contributor Author

TacoTheDank commented Dec 20, 2020 •
edited

@samfundev I have an idea about how to solve this. Instead of using position numbers manually, what about using an array that sets the number of tabs automatically (depending on whether subscriber emotes are enabled or not)? Like this.

I actually tried and got to a good point, but then I got crashes.

@TacoTheDank TacoTheDank force-pushed the viewpager2-chatfragment branch 3 times, most recently from edfa1a5 to c154f7e Compare January 27, 2021 15:53
@TacoTheDank
Copy link
Contributor Author

TacoTheDank commented Jan 27, 2021 •
edited

@samfundev I think I have successfully fixed the issue with the tabs. Here's an APK to test. app-debug.zip

The only bug left now I think is the scroll-jumping that I mentioned in the other PR.

EDIT: Nevermind, fuck.

Ok, well, the tablayout and viewpager themselves work fine, but the mood icon still does what I said in the other PR.

@TacoTheDank TacoTheDank force-pushed the viewpager2-chatfragment branch 4 times, most recently from dba12be to 5a69263 Compare January 30, 2021 21:42
@RickyM7
Copy link
Contributor

RickyM7 commented Jan 31, 2021

I tested the Debug Build and everything seemed to work perfectly (I at least didn't see any bugs, however I tested it without logging in).

  • Device: Redmi Note 4 (MIUI 11 - Android 7.0)

@TacoTheDank
Copy link
Contributor Author

TacoTheDank commented Jan 31, 2021 •
edited

@RickyM7 I'm pretty sure you'll have to log in to test it, as the chatting feature (not to be mistaken with the chat itself) does not appear if you are not logged in. It's a little bit of a hassle (having to input the 2FA code from your email and whatnot), but I have to do it whenever I'm testing as well lol

Also the APK is now outdated, so I'll have to fix it

@RickyM7
Copy link
Contributor

RickyM7 commented Jan 31, 2021

@TacoTheDank Got it! When the Apk is updated I will test correctly.

@TacoTheDank TacoTheDank force-pushed the viewpager2-chatfragment branch 2 times, most recently from 9b3095a to 28063a3 Compare February 1, 2021 00:03
@samfundev samfundev force-pushed the master branch 3 times, most recently from d5f4346 to c9b9c23 Compare July 9, 2022 23:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@TacoTheDank @RickyM7