Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#39150 : fix incorrect borders in list-group-horizontal #39192

Closed
wants to merge 0 commits into from

Conversation

Luciferxgkp
Copy link

@Luciferxgkp Luciferxgkp commented Sep 16, 2023

Description

Closes #39150

I Have tried to solve the issue of #39150 but i don't know how to test it locally. I am new to open source.

Screenshot from 2023-09-16 13-29-11

Motivation & Context

Type of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Refactoring (non-breaking change)
  • Breaking change (fix or feature that would change existing functionality)

Checklist

  • I have read the contributing guidelines
  • My code follows the code style of the project (using npm run lint)
  • My change introduces changes to the documentation
  • I have updated the documentation accordingly
  • I have added tests to cover my changes
  • All new and existing tests passed

Live previews

Related issues

@julien-deramond
Copy link
Member

julien-deramond commented Sep 16, 2023

Thanks for the PR @Luciferxgkp

As mentioned in our Contributing Guidelines:

Do not edit bootstrap.css or bootstrap.js, and do not commit any dist files (dist/ or js/dist). Those files are automatically generated by our build tools. You should edit the source files in /bootstrap/scss/ and/or /bootstrap/js/src/ instead.

Please update your PR.

i don't know how to test it locally

You can run npm i and then npm run start to have the documentation launched locally.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Incorrect borders with .list-group-flush.list-group-horizontal
2 participants